Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_rds_cluster: add enable_global_write_forwarding #17561

Closed
wants to merge 1 commit into from
Closed

resource/aws_rds_cluster: add enable_global_write_forwarding #17561

wants to merge 1 commit into from
+152 −0

Conversation

yehudacohen
Copy link
Contributor

@yehudacohen yehudacohen commented Feb 11, 2021 •
edited by YakDriver
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Superceded by #17111
Closes #14457

Output from acceptance testing:

➜  $ make testacc TESTARGS='-run=TestAccAWSRDSCluster_GlobalClusterIdentifier_SecondaryCluster'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRDSCluster_GlobalClusterIdentifier_SecondaryCluster -timeout 120m
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier_SecondaryClustersWriteForwarding
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier_SecondaryClustersWriteForwarding
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier_SecondaryClustersWriteForwarding
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_SecondaryClustersWriteForwarding (2014.79s)
PASS...

@yehudacohen yehudacohen requested a review from a team as a code owner February 11, 2021 07:50
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 11, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 11, 2021
github-actions[bot]
github-actions bot reviewed Feb 11, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @yehudacohen 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@danhurwit
Copy link

Hello, wondering what the status of this is and if there are plans to merge in the near future. Thanks.

@safakozdek
Copy link

Hey, There is a requirement for this feature. It would be helpful if you can review this PR as it is requested by many people in #14457

@chenrui333
Copy link

Any update on this PR?

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 4, 2021
@YakDriver YakDriver self-assigned this Oct 13, 2021
@YakDriver YakDriver mentioned this pull request Oct 13, 2021
Merged
@YakDriver
Copy link
Member

@yehudacohen Thank you for your work on this! This functionality was merged as part of #17111. Thank you for your interest.

@YakDriver YakDriver closed this Oct 13, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Enable Write forwarding on Aurora RDS Global Database Clusters
6 participants
@yehudacohen @danhurwit @safakozdek @chenrui333 @YakDriver @breathingdust